vk: Forgotten improvements

[kd-11]

This is a collection of minor optimizations and reworks that were done over the past few months. Should result in a minor performance boost in most RSX-limited scenarios when using Vulkan.

[digant73]

it does not compile on windows

[kd-11]

it does not compile on windows

Indeed. I haven't tested it on windows yet, this code was lost on my linux dev machine.

[AniLeo]

19a435e causes a ~10 FPS performance drop in dice

Undoing the commit brings back performance

[digant73]

does the PR cover #16843 (so possibly it could fix some DEVICE-LOST errors)?
Anyway, I will start to test the PR this night

[digant73]

some testing on FOM on the same place where I get a systematic DEVICE-LOST.
Something is wrong when managing the fault info. Below the error on log file

·F 0:01:57.908452 {RSX [0x1dd2308]} SIG: Thread terminated due to fatal error: Verification failed (object: 0x0)
(in file G:\console\git\rpcs3_kd-11\rpcs3\Emu\RSX\VK\vkutils\shared.cpp:20[:3], in function 'std::basic_string<char,std::char_traits<char>,std::allocator<char> > vk::retrieve_device_fault_info()') (error=0x578)

Attached the log file

RPCS3.log

[digant73]

Killzone 3 crashed when loading the selected chapter. Same crash for other games (KZ2, R3 etc.)

RPCS3.log

[AniLeo]

Looks good to me

[kd-11]

@digant73 Your killzone issue is fixed now?

[digant73]

@digant73 Your killzone issue is fixed now?

yes and also R3 etc. But I will test in deep in few hours

[digant73]

made some testing and I didn't see regressions. DEVICE-LOST issue is still there but it seems that issue was not the target of the PR

[kd-11]

Thanks for checking. I'll clean this up for merge.