Skip to content

Input: implement copiloting #17250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025
Merged

Input: implement copiloting #17250

merged 3 commits into from
May 29, 2025

Conversation

Megamouse
Copy link
Contributor

@Megamouse Megamouse commented May 25, 2025

  • This implements ingame copiloting.

How does it work?
Set the device class of any player to copilot for any other player.
Then that device will add to that player's input instead of being registered as its own device.

Fixes #11278

@Megamouse Megamouse force-pushed the copiloting branch 5 times, most recently from 549c498 to f2ca9ce Compare May 28, 2025 22:27
@Megamouse
Copy link
Contributor Author

Added copilot for any player (still selectable in device class)

@Megamouse Megamouse force-pushed the copiloting branch 2 times, most recently from af3bc0d to b257f7d Compare May 28, 2025 23:36
@Darkhost1999
Copy link
Contributor

I'm testing with my xbox controller on xinput + keyboard and while my keyboard is player 1. The xbox controller on player 7 with device class copilot player 1 doesn't seem to work in test title Skyrim Legendary Edition.
Just testing purposes.
I even tried setting copilot to Player 2. No inputs from the device class copilot player 1 device.
Unbinding all/some of Player 1 to test only using Player 2 if you can't double bind or something. Nothing. No inputs from device class copilot player 1 device.
RPCS3.log

@Megamouse
Copy link
Contributor Author

Megamouse commented May 29, 2025

@Darkhost1999

Should be fixed now

@Darkhost1999
Copy link
Contributor

LGTM, I tried most the inputs abxy select start moving analog sticks, moving triggers, bumpers, PShome button on both the keyboard and xbox controller being used to copilot. This appears to work well. Can dual bind buttons, simultaneously use both pads, and generally feels easy to use. I imagine some streamer might use this functionality for chat to control their game or that person thought of local co-op brothers a tale of two sons.

@Megamouse Megamouse merged commit 382e62c into RPCS3:master May 29, 2025
5 of 8 checks passed
@Qaim155
Copy link

Qaim155 commented May 29, 2025

Just tried the copilot feature, it's working smoothly.
You guys are really great, fast like flash. I am product manager in a software startup, and I can tell you guys are really fast paced, because normally features don't get released so fast.
I asked for this feature for my own selfish reason, but this will really improve the accessibility of the emulator. This will actually benefit someone with physical disability who wants to play ps3 games on rpcs3 with their partner. I have read such stories for Xbox.
Thanks again, great work!

@Megamouse Megamouse deleted the copiloting branch May 30, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Copiloting
3 participants