Fix handlebars url fetch #5807
Merged
Fix handlebars url fetch #5807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwisniew
requested changes
Oct 9, 2025
github-project-automation
bot
moved this from Awaiting-Review
to In-Progress
in MapTool 1.19
Handlebars don't have their own MIME type so Tika doesn't consider checking whether something that looks like HTML has handlebars substitutions. Since identifying handlebars unambiguously by content is hard but the Handlebars partial template loader requires them to end .hbs we can use that to identify the type.
We have filenames and passing them can help identify files correctly.
fishface60
force-pushed
the
fix-handlebars-url-fetch
branch
from
55ce8a7 to
ed793b7
Compare
cwisniew
approved these changes
Oct 19, 2025
github-project-automation
bot
moved this from In-Progress
to To-Be-Merged
in MapTool 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing a Bug Fix or Enhancement
and possibly closure of the pull request if it is not provided after this request.
Identify the Bug or Feature request
Fixes #5806
Description of the Change
This passes the file path to file type deduction in more places
Possible Drawbacks
There may be valid handlebars partial templates that don't appear to be html and wouldn't get returned as Type.HANDLEBARS.
Release Notes
This change is