Skip to content

Generalize BISG function to handle custom surname / geographic input #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pssachdeva opened this issue Sep 20, 2021 · 0 comments
Open
Assignees

Comments

@pssachdeva
Copy link
Contributor

pssachdeva commented Sep 20, 2021

Currently, the package assumes that BISG will merge with WRU's surname2010 dataframe. This needs to be extended to allow the user to provide their own surname dataframe.

The following changes must be made:

  • compute_p_r_cond_s: this function needs to accept a surname dataframe, which defaults to NONE. If NONE, then merge_surnames from wru is called. Otherwise, the merge occurs with the provided dataframe. This should also include a race_cols argument, defaulting to the standard in wru.
  • compute_p_r_cond_s_g: this function needs to accept a surname dataframe, as described above.
  • bisg: this function needs to accept a surname dataframe, as described above.
@aridf aridf self-assigned this Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants