Skip to content

Generalize bisg inputs #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 22, 2021
Merged

Generalize bisg inputs #6

merged 5 commits into from
Sep 22, 2021

Conversation

aridf
Copy link
Contributor

@aridf aridf commented Sep 21, 2021

Addressing #5. Adds

  • Enables the use of custom surname lookup tables.
  • Some basic tests that bisg outputs the correct results when using custom lookups for surname and geography.
  • Handles unknown surnames in the custom table by taking the unweighted mean probability across the table

@aridf aridf requested a review from pssachdeva September 21, 2021 00:23
@pssachdeva
Copy link
Contributor

This looks good to me. I left a comment in there about something small. Feel free to merge if it successfully passes tests.

@aridf aridf merged commit 571d7f4 into main Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pssachdeva pssachdeva Awaiting requested review from pssachdeva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aridf @pssachdeva