Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YouTubeFeedExpanderBridge] Add bridge #4430

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

Phantop
Copy link
Contributor

@Phantop Phantop commented Jan 28, 2025

Adds a new YouTube bridge based on feed expander. The current one works fine, however is rather complex due to using the YouTube private API to obtain most data. This bridge uses feed expander over the official feeds, which function fine, to add some functionality not in that existing bridge:

  • Properly obtains channel icons as feed icon
  • Includes maxres thumbnail in enclosures
  • Provides options to include embed iframe, use embed as entry url, and use nocookie version for those

@dvikan
Copy link
Contributor

dvikan commented Jan 29, 2025

I like that it's shorter/lesser code. Supports only channel id.

but but do we really want to have two kinds of youtube bridges? users gonna get confused?

@Phantop Phantop force-pushed the youtube branch 2 times, most recently from 3693bec to 4aebf10 Compare January 30, 2025 00:38
Copy link

Pull request artifacts

Bridge Context Status
YouTubeFeedExpander 1 untitled (pr) ✔️

last change: Thursday 2025-01-30 00:47:30

@Phantop
Copy link
Contributor Author

Phantop commented Feb 4, 2025

Forgot to comment—I do think this bridge has its uses, with the functionality I added being useful stuff that is commonly added in feeds for alt YouTube frontends.

I'm proposing this as an alt bridge rather than replacing the existing one because that one has been around for a while and takes a very different approach. I don't want to break any existing feeds. It's up to you what the best way to include this would be.

@dvikan dvikan merged commit 549bed6 into RSS-Bridge:master Feb 4, 2025
9 checks passed
@dvikan
Copy link
Contributor

dvikan commented Feb 4, 2025

ok cool. adding it as an alternative. we will see how it goes. maybe improve bridge explanation that this is an alternative to the main

@dvikan
Copy link
Contributor

dvikan commented Feb 4, 2025

Also interesting to note that the JsonFormat actually includes the yt module in its _rssbridge key:

https://rss-bridge.org/bridge01/?action=display&bridge=YouTubeFeedExpanderBridge&channel=UCzORJV8l3FWY4cFO8ot-F2w&embed=on&format=Json

Only JsonFormat does this (adding extra meta data)

@dvikan
Copy link
Contributor

dvikan commented Feb 4, 2025

Also unfortunately that the HtmlFormat actually htmlencodes the <iframe>. We could change that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants