Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RedditBridge] Added time interval and filter for min comment count #4471

Merged
merged 4 commits into from
Mar 23, 2025

Conversation

chibicitiberiu
Copy link
Contributor

When using the 'top' sorting order for reddit, most times you want to limit to a time interval (e.g. top in the last month). In the search UI, there is a time interval filter that will end up as a query parameter t=interval .

Also, added filtering and sorting by comment count.

Copy link

github-actions bot commented Mar 9, 2025

Pull request artifacts

Bridge Context Status
Reddit 1 single (current) HTTP status 429 Too Many Requests
Type: RateLimitException
Message:
Reddit 1 single (pr) HTTP status 429 Too Many Requests
Type: RateLimitException
Message:
Reddit 2 multi (current) HTTP status 429 Too Many Requests
Type: RateLimitException
Message:
Reddit 2 multi (pr) HTTP status 429 Too Many Requests
Type: RateLimitException
Message:
Reddit 3 user (current) HTTP status 429 Too Many Requests
Type: RateLimitException
Message:
Reddit 3 user (pr) HTTP status 429 Too Many Requests
Type: RateLimitException
Message:

last change: Sunday 2025-03-23 19:41:45

@dvikan
Copy link
Contributor

dvikan commented Mar 23, 2025

i dont understand the purpose of having if, elseif, elseif for filtering on score and comment count

@dvikan
Copy link
Contributor

dvikan commented Mar 23, 2025

anyways, it works...

@dvikan dvikan merged commit 7260f28 into RSS-Bridge:master Mar 23, 2025
9 checks passed
@chibicitiberiu
Copy link
Contributor Author

i dont understand the purpose of having if, elseif, elseif for filtering on score and comment count

I thought it made more sense, if both a minimum score and minimum number of comments are provided, the filter does an OR between these 2 conditions rather than an AND (e.g. if a post gets a lot of comments but not a lot of upvotes, it probably has an interesting discussion that might be worth seeing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants