Skip to content

add len on DocIndex #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RStar2022 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add len on DocIndex #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc34e94
add len on DocIndex
RStar2022 Apr 25, 2023
509e918
Merge branch 'main' into feat-len
RStar2022 Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docarray/index/abstract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,3 +900,6 @@ def _dict_list_to_docarray(self, dict_list: Sequence[Dict[str, Any]]) -> DocList
doc_list = [self._convert_dict_to_doc(doc_dict, self._schema) for doc_dict in dict_list] # type: ignore
docs_cls = DocList.__class_getitem__(cast(Type[BaseDoc], self._schema))
return docs_cls(doc_list)

def __len__(self) -> int:
return self.num_docs()
8 changes: 7 additions & 1 deletion tests/index/base_classes/test_base_doc_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def python_type_to_db_type(self, x):
return str

_index = _identity
num_docs = _identity
num_docs = lambda n: 3
_del_items = _identity
_get_items = _identity
execute_query = _identity
Expand Down Expand Up @@ -572,3 +572,9 @@ def test_validate_search_fields():
# 'ten' is not a valid field
with pytest.raises(ValueError):
index._validate_search_field('ten')


def test_len():
store = DummyDocIndex[SimpleDoc]()
count = len(store)
assert count == 3