Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kernel] move std libc related to rtklibc.h #8594

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

mysterywolf
Copy link
Member

@mysterywolf mysterywolf commented Mar 10, 2024

拉取/合并请求描述:(PR description)

[

kservice.c.h 里承载的东西过多、过杂,将rt标准库相关的函数迁移至rtklibc.h以及klibc文件夹下

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf mysterywolf marked this pull request as draft March 10, 2024 17:49
@mysterywolf mysterywolf force-pushed the api branch 2 times, most recently from 5c81aac to 30def4f Compare March 10, 2024 18:13
@mysterywolf mysterywolf requested a review from Rbb666 March 10, 2024 18:26
@mysterywolf mysterywolf marked this pull request as ready for review March 10, 2024 18:26
@mysterywolf mysterywolf linked an issue Mar 10, 2024 that may be closed by this pull request
11 tasks
@mysterywolf mysterywolf deleted the api branch March 10, 2024 18:54
@mysterywolf mysterywolf removed a link to an issue Mar 10, 2024
11 tasks
@mysterywolf mysterywolf restored the api branch March 10, 2024 20:07
@mysterywolf mysterywolf reopened this Mar 10, 2024
@mysterywolf mysterywolf added v5.1.0 version 5.1.0 (planned to be released by the end of 2023) and removed v5.1.1 labels Mar 10, 2024
@BernardXiong
Copy link
Member

需要这样?或者也可以考虑怎么把kservice.c给进行精简?

@mysterywolf
Copy link
Member Author

mysterywolf commented Mar 11, 2024

高度建议合并,这个我很早之前就想搞了,kservice精简比较难,主要是精简什么?这些函数哪个都会被用户和软件包大量使用。

@BernardXiong
Copy link
Member

问题是在kernel这边又多出来了这么一个klibc目录,然后又是更多的文件

@BernardXiong BernardXiong added the discussion This PR/issue needs to be discussed later label Mar 13, 2024
@mysterywolf
Copy link
Member Author

我觉得kernel如果为了文件少,把所有的东西都塞到一个文件里会很不优雅的

@polarvid
Copy link
Contributor

问题是在kernel这边又多出来了这么一个klibc目录,然后又是更多的文件

kservice 里面类似 klibc 的定义分出来应该是有必要的。smart 的工具链也是想着往 klibc 去演进,摒弃和用户态共用的方式。所以,现在分出来也是往这个方向慢慢靠近。

@mysterywolf mysterywolf merged commit e81978c into RT-Thread:master Mar 21, 2024
41 checks passed
@mysterywolf mysterywolf deleted the api branch March 21, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This PR/issue needs to be discussed later v5.1.0 version 5.1.0 (planned to be released by the end of 2023)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants