-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kernel] move std libc related to rtklibc.h #8594
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysterywolf
force-pushed
the
api
branch
2 times, most recently
from
March 10, 2024 18:13
5c81aac
to
30def4f
Compare
Open
11 tasks
mysterywolf
added
v5.1.0
version 5.1.0 (planned to be released by the end of 2023)
and removed
v5.1.1
labels
Mar 10, 2024
需要这样?或者也可以考虑怎么把kservice.c给进行精简? |
高度建议合并,这个我很早之前就想搞了,kservice精简比较难,主要是精简什么?这些函数哪个都会被用户和软件包大量使用。 |
Rbb666
approved these changes
Mar 12, 2024
问题是在kernel这边又多出来了这么一个klibc目录,然后又是更多的文件 |
我觉得kernel如果为了文件少,把所有的东西都塞到一个文件里会很不优雅的 |
kservice 里面类似 klibc 的定义分出来应该是有必要的。smart 的工具链也是想着往 klibc 去演进,摒弃和用户态共用的方式。所以,现在分出来也是往这个方向慢慢靠近。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
discussion
This PR/issue needs to be discussed later
v5.1.0
version 5.1.0 (planned to be released by the end of 2023)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
kservice.c.h 里承载的东西过多、过杂,将rt标准库相关的函数迁移至rtklibc.h以及klibc文件夹下
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up