-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CI script assigns PR reviews based on the list of maintainers #9913
base: master
Are you sure you want to change the base?
Conversation
3e75f0a
to
8d799f2
Compare
你这个要加RTTHREAD_GITHUB_TOKEN的吧 |
目前这个仓库里面的RTTHREAD_GITHUB_TOKEN 加了吗?还没有加吧? |
没有的,那个是我加的。token你找熊大加一下。 |
噢噢好的,那我另设一个 |
8d799f2
to
93f979c
Compare
不是我的意思是你还是用RTTHREAD_GITHUB_TOKEN 这个就可以了。这个settings里面的值没有赋值。 |
93f979c
to
6a39a62
Compare
@BernardXiong 熊大,麻烦帮忙添加个名为 GITHUB_TOKEN_COMMENT 的token可以嘛,只需要拥有对仓库的评论权限就可以了 |
我想了解一下这个工作是否可以和 #9903 结合起来? 具体来说,就是我想问一下,我们是否可以维护一个 MAINTAINER 文件(MAINTAINER 文件中记录了 reviewer 的相关信息),然后利用 MAINTAINER 文件 中的信息来指定 reviewer? 为啥要用 label 信息?感觉 label 信息以后扩展方便吗? |
6a39a62
to
369074a
Compare
70252d0
to
97ebf5a
Compare
|
97ebf5a
to
ba0c8f9
Compare
回复提出的问题: |
ba0c8f9
to
cdff117
Compare
Fixed #9903
Ps:该CI自动化脚本可自动识别PR修改的文件列表,并根据仓库根目录下的MAINTAINERS文件,映射审核团所维护的path,从而分配审查
下面是该脚本的具体功能说明:
此外,为避免因PR多次修改而重复@审核者,该脚本还引入缓存机制,仅在第一次@时评论提及,后续仅提示GitHub id
下面是一个演示效果,也可以通过下方链接查看实际效果:
📌 Code Review Assignment
🏷️ Tag: stm32
Path:
bsp/stm32
Reviewers: @kurisaW
Changed Files (Click to expand)
🏷️ Tag: kernel
Path:
src
Reviewers: @kurisaW @Nedki-L
Changed Files (Click to expand)
🏷️ Tag: workflow
Path:
.github/workflows
Reviewers: @kurisaW @Nedki-L @KurisaW-Collaborative
Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-01-23 06:31 UTC)
📝 Review Instructions
维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论
LGTM/lgtm
Comment
LGTM/lgtm
after confirming approvalPR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging