leveldb: fix empty opts causing panic and add test

RTradeLtd · May 9, 2020 · cc52fd8 · cc52fd8
1 parent 862d402
commit cc52fd8
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/leveldb/datastore.go b/leveldb/datastore.go
@@ -37,7 +37,10 @@ type Options = opt.Options
 
 // NewDatastore returns a new datastore backed by leveldb
 func NewDatastore(path string, opts *Options) (*Datastore, error) {
-	noSync := opts.NoSync
+	var noSync bool
+	if opts != nil {
+		noSync = opts.NoSync
+	}
 	db, err := leveldb.OpenFile(path, opts)
 	if err != nil {
 		return nil, err

diff --git a/leveldb/ds_test.go b/leveldb/ds_test.go
@@ -119,6 +119,18 @@ func testQuery(t *testing.T, d *Datastore) {
 	expectOrderedMatches(t, keys, rs)
 }
 
+func TestEmptyOpts(t *testing.T) {
+	path := "emptyoptstest"
+	ds, err := NewDatastore(path, nil)
+	if err != nil {
+		t.Fatal(err)
+	}
+	if err := ds.Close(); err != nil {
+		t.Fatal(err)
+	}
+	os.RemoveAll(path)
+}
+
 func TestQuery(t *testing.T) {
 	d, close := newDS(t)
 	defer close()