Skip to content

Conversation

MarkCiliaVincenti
Copy link

No description provided.

@MarkCiliaVincenti
Copy link
Author

@majiccode please let me know

@avmgan
Copy link
Collaborator

avmgan commented Feb 12, 2024

current develop branch merged DXA 2.3 release related changes, it's conflicting your changes.
I think better we can keep AsynKeylockCacheProvider separate class, people can choose which caching machanism they want rather than overriding the exisitng options, if you raise a new PR by keeping the new class, I can review and merge it. if not I can plan to this change sometime later.

@majiccode
Copy link
Contributor

@MarkCiliaVincenti looks good to me :)

@MarkCiliaVincenti
Copy link
Author

@MarkCiliaVincenti looks good to me :)

Check now pls.

@MarkCiliaVincenti
Copy link
Author

@majiccode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants