Add issue approval readiness checklist (#144)

[d3vobed]

Description

Creates an Issue Approval Readiness Checklist that contributors and reviewers can use before considering an issue ready for GrantFox evaluation. The checklist covers all key areas — implementation completeness, testing expectations, CI status, acceptance criteria review, documentation, and known limitations — and explicitly states that merged PRs are still subject to evaluation.

Closes: #144

Type of Change:

• Bug fix
• New feature
• Breaking change
• Documentation (changes to documentation only)
• Refactor
• CI/CD

---

Evidence Checklist

1. Issue Reference

• This PR references a tracked issue (Closes #144)
• Issue Link: Add Aegis Dashboard issue approval readiness checklist #144

2. Implementation Summary

• A clear summary of what was changed and why is provided above
• Files Changed:
  • docs/issue-approval-readiness-checklist.md (new) — Pre-evaluation checklist with 6 sections: implementation completeness, testing expectations, CI status, acceptance criteria review, documentation, and known limitations. Includes a prominent "Merge ≠ Evaluation" disclaimer at the top and a self-review flow at the end
  • README.md (modified) — Added the new checklist to the key resources list, right after the evaluation-readiness index

3. Testing

• Tests have been added or updated to cover the changes
• All existing tests pass locally
• If tests are not applicable, explain why:
  Documentation-only change — no testable logic was introduced. The new document is a Markdown checklist file.

Test Commands Run:

npm run lint
npm run build

Test Output (summary or screenshot):

Documentation-only change — all existing tests, lint, and build checks are unaffected.

4. Commands Run

• The following commands were executed locally to validate the change:

npm run lint
npx tsc --noEmit
npm run build
npm test

5. CI Status

• All CI checks will pass on this PR
• No new warnings or errors were introduced
• CI Pipeline Link (if available): N/A

6. Acceptance Criteria Coverage

• All acceptance criteria from the linked issue have been satisfied
• Criteria Mapping:

Acceptance Criterion	Evidence	File
Approval readiness checklist is added	Full checklist document created with 6 sections covering all required areas	docs/issue-approval-readiness-checklist.md
Checklist states that merged PRs are still subject to evaluation	Prominent "Important: Merge ≠ Evaluation" disclaimer at the top, referencing the Contributor Payment Guide	docs/issue-approval-readiness-checklist.md (line 11-13)
Testing expectations are included	Section 2 "Testing Expectations" covers test coverage, passing tests, UI screenshots, and negative-path tests	docs/issue-approval-readiness-checklist.md (section 2)
CI status expectations are included	Section 3 "CI Status" covers lint, type check, build, tests, and documenting resolved failures	docs/issue-approval-readiness-checklist.md (section 3)
Acceptance criteria review is included	Section 4 "Acceptance Criteria Review" covers criteria-to-evidence mapping and PR traceability table	docs/issue-approval-readiness-checklist.md (section 4)
README links to the checklist	New checklist added as the second entry in the key resources list under Contributing	README.md

---

Screenshots / Recordings

N/A — documentation-only change.

---

Reviewer Notes

This checklist complements the existing Self-Assessment Checklist (for pre-submit use) and the Review Quality Checklist (for reviewers). It fills the gap between PR merge and GrantFox evaluation, giving contributors a clear final gate to pass before requesting payment review. All references link to existing docs.

[El-swaggerito]

\nThis PR is currently blocked by merge conflicts.\n\nPlease update the branch with the latest main branch and resolve the conflicts before it can be merged.

[El-swaggerito]

\nGitHub has not finished calculating whether this PR can be merged cleanly.\n\nThe auto-merge automation will skip this PR for now. Re-run the automation later.

[d3vobed]

@El-swaggerito finish fix merge pr