Refactor

[Wiechciu]

A couple of refactors:

• Refactored context menu item creation to use much easier EditorContextMenuPlugin instead of manually manipulating the popup menu.
• Added check for .fbx files so that context menu item is added only when at least one .fbx file is selected and not every time like it is now.
• Changed some methods like to_snake_case() to use the built in logic instead of the custom made.
• Removed the destination direction selection, using the source location by default - makes the process much quicker, users can move the files later if they want.
• Removed unused and unnecessary methods.
• Left unchanged the main logic of the _process_fbx_file() method.

[Wiechciu]

Hi @mattmarcin
Can you review and test on your side?
Let me know if something is unclear, if you don't feel like this is a good approach to take with this addon, or anything else. I'm happy to revisit the idea and help you develop a better solution.

Thanks!

[mattmarcin]

Will review this week. Thanks for the contributions!

[DigitallyTailored]

It would be great to get these bits in

[Wiechciu]

Hi @mattmarcin, any progress on this topic?
I haven't tested myself, but apparently your version breaks in 4.6, while my refactors make it still work
https://bsky.app/profile/mieko.dev/post/3malpthx7js26

Thanks in advance!

[geri1245]

Nice, changes, thanks for fixing this for 4.6!

[geri1245]

This will return true if the first file is fbx, even if the rest is not. I think, this is what you were looking for:

Suggested change

	func _validate_paths(paths: Array) -> bool:
	for path: String in paths:
	if path.get_extension() == "fbx":
	return true
	return false
	func _validate_paths(paths: Array) -> bool:
	for path: String in paths:
	if path.get_extension() != "fbx":
	return false
	return true

Oh, I see that this is only for the context menu to appear. Still, I think that the retarget option should only be shown if only fbx files are selected. But it also works as it is 👍

[ssebs]

Hey just wanted to chime in here, I've spent some time trying to get this working, I had to make 2 changes for my setup (after copying the changes in #5)

1. Enable subresources["animations"]["mixamo_com"]["save_to_file/keep_custom_tracks"] = true
2. Create a brand new BoneMap + SkeletonProfileHumanoid in my FBX, overwrite the default one.