This repository was archived by the owner on Aug 3, 2026. It is now read-only.
validator: reject cleanly when op4 eval fails (no scoring crash) - #64
Merged
Conversation
bitzic
commented
Jun 26, 2026
bitzic
commented
Contributor
- op4 returns (False, detail, None) when a checkpoint won't load into RalphBase and the patched-workdir re-eval also fails; judge_submission stored hidden_eval=None and returned a "passing" result
- score_and_decide then dereferenced None.val_bpb -> AttributeError that took down the whole epoch loop (a DoS surface for any unloadable ckpt)
- mirror op1-op3: on op4 failure set result.rejected and return
- score_and_decide: defense-in-depth None-guard before .val_bpb
- test: op4 failure rejects cleanly with reason op4_hidden_eval
- op4 returns (False, detail, None) when a checkpoint won't load into RalphBase and the patched-workdir re-eval also fails; judge_submission stored hidden_eval=None and returned a "passing" result - score_and_decide then dereferenced None.val_bpb -> AttributeError that took down the whole epoch loop (a DoS surface for any unloadable ckpt) - mirror op1-op3: on op4 failure set result.rejected and return - score_and_decide: defense-in-depth None-guard before .val_bpb - test: op4 failure rejects cleanly with reason op4_hidden_eval Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.