Fix: Accept Signed FROST Transactions as Input#193
Merged
Conversation
…TransactionSignature as input, only raw unsigned ZkApp or Legacy transaction JSON. This means the output of one FROST signing session cannot be fed as input to a subsequent signing session, preventing chained multi-group signing of the same transaction. The test uses a real signed fixture from a deploy-v0.0.6 ceremony and currently fails documenting the limitation.
…FROST signing session) as input to from_str_network, enabling chained multi-group signing where the output of one signing session is fed directly as input to the next. The parser now tries TransactionSignature first and extracts the inner payload which already contains the previous groups injected signature, then falls back to the existing ZkApp and Legacy parsing. Resolves the failing test from the previous commit.
jCabala
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See pr #191 for the full information. I've opened a new PR as I don't have write access to the original PR. Closes #189