release: v0.7.0 — scan QoL + fix Settings live-update bug - #116
Merged
Conversation
Bump VERSION to 0.7.0 and update docs/changelog for the exclusion list, streaming results, cancel-keeps-partial, pause/resume, and redaction toggle features from PRs #113/#114. While verifying the release build, found that FilterStore's @published changes never propagated into ScanStore's own objectWillChange (filters is a lazy var, not @published, and nothing forwarded its changes). Every view holds @ObservedObject var store: ScanStore, so Settings toggles/steppers appeared stuck — the underlying value did change, but nothing forced SwiftUI to re-render the control showing it, until some unrelated action (e.g. switching sidebar views) happened to trigger ScanStore's own objectWillChange. This predates this release (reproduces on the already-shipped v0.6.0 build) but was only now caught during manual verification. Fixed by forwarding filters.objectWillChange and onDemandVerification.objectWillChange into ScanStore's own objectWillChange. Also fixed two redaction-toggle path leaks found during manual testing: the sidebar's recent-scans list/status footer and the Overview header both showed the real scan root path even with redaction enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FilterStore's@Publishedchanges never propagated intoScanStore's ownobjectWillChange(filtersis alazy var, not@Published, with nothing forwarding its changes). Since every view holds@ObservedObject var store: ScanStore, Settings toggles/steppers appeared stuck — the underlying value did change, but nothing forced a re-render of the control showing it until some unrelated action (e.g. switching sidebar views) happened to triggerScanStore's ownobjectWillChange. This reproduces on the already-shipped v0.6.0 build (bisected), so it predates this release, but was only caught now during manual verification of the redaction toggle. Fixed by forwarding bothfilters.objectWillChangeandonDemandVerification.objectWillChangeintoScanStore's ownobjectWillChange.Test plan
swift build/swift build -c releasecleanswift test— 190/190 passing./script/public_upload_audit.shpassing--fixture-scan: exclusion list, redaction toggle (Settings, Largest Files, Overview header, sidebar footer, Recent Scans), and Settings toggle now live-updates without needing to reopen the window./script/export_dmg.shproduces a valid, checksum-verifiedStorageScope-0.7.0.dmg