Open
Conversation
SSID's are allowed to contain single quotes ('). This change allows the configurator to work with SSID's (and passphrases) to contain single quotes.
Previous version causes following behavior:
SSID: It's a great network name
Pass: RatOSIsGreat
$ wpa_passphrase 'It's a great network name' 'RatOSIsGreat'
This won't work, so it should be
$ wpa_passphrase "It's a great network name" "RatOSIsGreat"
hence this change
Member
|
Thanks! I think a better solution is to use spawn instead of exec, we don't need to quote or escape the arguments that way (but the process can be orphaned, although that seems like an OK tradeoff here). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSID's are allowed to contain single quotes ('). This change allows the configurator to work with SSID's (and passphrases) to contain single quotes. Previous version causes following behavior:
$ wpa_passphrase 'It's a great network name' 'RatOSIsGreat'This won't work, so it should be
$ wpa_passphrase "It's a great network name" "RatOSIsGreat"hence this change