Feature/project avatar #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added avatar removal show project avatar on dashboard, projects page, project page added rspec and feature tests added project avatar from repository new default project icon added added copying af avatar to forking of project added generated icon fixed avatar fork hound fix style fix test fix
… into feature/project-avatar Conflicts: app/assets/javascripts/project.js.coffee app/assets/stylesheets/sections/dashboard.scss app/models/project.rb app/views/projects/_home_panel.html.haml spec/models/project_spec.rb
app/helpers/application_helper.rb
Outdated
There was a problem hiding this comment.
Align the elements of a hash literal if they span more than one line.
app/models/project.rb
Outdated
There was a problem hiding this comment.
Align the parameters of a method call if they span more than one line.
Avoid using {...} for multi-line blocks.
Block body expression is on the same line as the block start.
Razer6
commented
Sep 14, 2016
| $('.js-choose-project-avatar-button').bind "click", -> | ||
| form = $(this).closest("form") | ||
| form.find(".js-project-avatar-input").click() | ||
|
|
| text-align: center; | ||
| vertical-align: top; | ||
|
|
||
| &.s16 { font-size: 12px; line-height: 1.33; } |
| margin-bottom: 15px; | ||
|
|
||
| border: 1px solid #EEE; | ||
| padding: 8px 12px; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.