-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Brazilian .po files #6776
Conversation
This reverts commit c88ece6.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6776 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 79 79
Lines 14642 14642
=======================================
Hits 14444 14444
Misses 198 198 ☔ View full report in Codecov by Sentry. |
Hi @MichaelChirico! Can you please remind me how can I update the source strings of a PO file and get the number of chars per line wrapped as is in the data.table repository? The translation editor software re-wrapped so the git diff looks polluted. |
I update the .po files with |
Sadly no. I don't exactly how po_update works, but it didn't update R-/pt_BR.po files. I even replaced POT-Creation-Date to some previous date, but it didn't touch them. |
Thanks. Feel free to just leave the .po update in the format your editor has in this PR, and I'll be sure to get it into the nicer format to reduce the diff before squash+merge. |
Done, PO file updated. Translation by @leofontenelle, proofread by me. Chirico, I'd love to know how to adjust the line wrap, if you can check it later and share will me. Thanks in advance! |
Hi @rffontenelle, I ran I also made one correction: there are two messages for "too-many" vs. "too-few", I saw "muito poucos" for both in Portuguese, looked wrong. I think the correction is just "muitos" for the "too-many" case. For the wrapping, AFAICT it's properly wrapped (I looked at the profile of PTAL. |
Indeed that's not correct. I'll take a look a them. Just for the record:
|
@leofontenelle pt_BR.po translated, feel free to review. Now I'm working on R-pt_BR.po |
@MichaelChirico Looks like the line-wrapping problem is not the number of chars, but where to wrap. I'm using Gtranslator and it seems to not break The resulting string is the same, but the commit diff gets a bit polluted with these different line-wrapping rules. For the last commit, I manually undid the wrapping-only changes done by my editor. |
R-pt_BR translated. 2 strings fuzzy because I was not sure how to translate it. Pending review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pedi dois ou três ajustes nos comentários
@MichaelChirico ready to merge! |
Ah, interesting. Are you aware of a standard on this? Possible I have some wrong logic in {potools}... IIRC I based my own rule on what would leave the r-devel .po files with minimal diff, so that might be something else to check (i.e. does Gtranslator mess extensively with the .po files of r-devel). |
Thanks! I deleted the deprecated ( I noticed there are two remaining fuzzy translations reported: msgfmt -c --statistics -o inst/po/pt_BR/LC_MESSAGES/data.table.mo po/pt_BR.po
# 667 translated messages.
msgfmt -c --statistics -o inst/po/pt_BR/LC_MESSAGES/R-data.table.mo po/R-pt_BR.po
# 567 translated messages, 2 fuzzy translations. It looks like it's these:
Since it's only two I'll go ahead and merge here since I want to be sure this is included in 1.17.0. Feel free to file a quick follow-up & it still might make the release. |
Thanks in advance!