Skip to content

Conversation

@validcube
Copy link
Member

@validcube validcube commented Aug 3, 2025

Bump dependencies on every ecosystems, optimise the heck out of Gradle from 445s to 184s (170s execution) on my pc on gradle assembleDebug (clean build), and make CI work again

I hate android studio

Make projects type safe, migrate major breaking based on their documentation except for Placeholder that i didn't bother

Axelen123 and others added 30 commits May 20, 2025 14:01
@validcube validcube marked this pull request as ready for review August 3, 2025 13:49
Copy link
Member

@Axelen123 Axelen123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested to ensure the app isn't broken by the dependency bumps?

@validcube
Copy link
Member Author

Have you tested to ensure the app isn't broken by the dependency bumps?

Not that I know of, patching is fine, settings is fine, navigation is fine.

@validcube validcube marked this pull request as draft August 7, 2025 11:31
@validcube
Copy link
Member Author

I'll put this into draft, awaiting #2663 merge.

@validcube validcube marked this pull request as ready for review September 3, 2025 10:18
@validcube validcube requested a review from Axelen123 September 23, 2025 11:41
@validcube validcube marked this pull request as draft September 23, 2025 11:57
@validcube validcube marked this pull request as ready for review September 23, 2025 15:22
pull_request:
branches:
- dev
- compose-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that a release is incoming, yes.

Suggested change
- compose-dev

compileSdk = 35
buildToolsVersion = "35.0.1"
compileSdk = 36
buildToolsVersion = "36.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this even necessary now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're bumping the target and compile sdk to 36, so it would also be appropriate to update the build tools to 36 also. (even though using 35.0.0 or 36.1.0 or 34.0.0 is fine really but it doesn't make sense.)

}

buildTypes {
configureEach {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftovers, forgot to remove.

fun LocalDateTime.relativeTime(context: Context): String {
try {
val now = Clock.System.now()
val now = kotlin.time.Clock.System.now()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please import it

Copy link
Member Author

@validcube validcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now feel free to skip this PR, I don't think PR should be dealt with before release because this is only bumping dependencies and overall build performance.

pull_request:
branches:
- dev
- compose-dev
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that a release is incoming, yes.

Suggested change
- compose-dev

compileSdk = 35
buildToolsVersion = "35.0.1"
compileSdk = 36
buildToolsVersion = "36.0.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're bumping the target and compile sdk to 36, so it would also be appropriate to update the build tools to 36 also. (even though using 35.0.0 or 36.1.0 or 34.0.0 is fine really but it doesn't make sense.)

}

buildTypes {
configureEach {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftovers, forgot to remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.