-
-
Couldn't load subscription status.
- Fork 944
build: Bump all dependencies across every ecosystems #2690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
I can't believe this happened
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested to ensure the app isn't broken by the dependency bumps?
Not that I know of, patching is fine, settings is fine, navigation is fine. |
|
I'll put this into draft, awaiting #2663 merge. |
| pull_request: | ||
| branches: | ||
| - dev | ||
| - compose-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that a release is incoming, yes.
| - compose-dev |
| compileSdk = 35 | ||
| buildToolsVersion = "35.0.1" | ||
| compileSdk = 36 | ||
| buildToolsVersion = "36.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this even necessary now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're bumping the target and compile sdk to 36, so it would also be appropriate to update the build tools to 36 also. (even though using 35.0.0 or 36.1.0 or 34.0.0 is fine really but it doesn't make sense.)
| } | ||
|
|
||
| buildTypes { | ||
| configureEach { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftovers, forgot to remove.
| fun LocalDateTime.relativeTime(context: Context): String { | ||
| try { | ||
| val now = Clock.System.now() | ||
| val now = kotlin.time.Clock.System.now() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please import it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now feel free to skip this PR, I don't think PR should be dealt with before release because this is only bumping dependencies and overall build performance.
| pull_request: | ||
| branches: | ||
| - dev | ||
| - compose-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that a release is incoming, yes.
| - compose-dev |
| compileSdk = 35 | ||
| buildToolsVersion = "35.0.1" | ||
| compileSdk = 36 | ||
| buildToolsVersion = "36.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're bumping the target and compile sdk to 36, so it would also be appropriate to update the build tools to 36 also. (even though using 35.0.0 or 36.1.0 or 34.0.0 is fine really but it doesn't make sense.)
| } | ||
|
|
||
| buildTypes { | ||
| configureEach { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftovers, forgot to remove.
Bump dependencies on every ecosystems, optimise the heck out of Gradle from 445s to 184s (170s execution) on my pc on gradle assembleDebug (clean build), and make CI work again
I hate android studio
Make projects type safe, migrate major breaking based on their documentation except for Placeholder that i didn't bother