-
Notifications
You must be signed in to change notification settings - Fork 164
Release Show Inserted Instrument on Currently Selected Track v1.0 #1569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Release Show Inserted Instrument on Currently Selected Track v1.0 #1569
Conversation
-- Wait and check if window was actually opened | ||
reaper.defer(function() | ||
for i = 0, fxCount - 1 do | ||
local isInstrument = reaper.TrackFX_GetInstrument(track, i) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TrackFX_GetInstrument
does not take an index parameter and it does not return whether the window was actually opened? You've used this correctly in another script though...
local instrumentCommandID = reaper.NamedCommandLookup('_RScd7a8ee199006214f53cef679139702356791f76') -- Custom action | ||
|
||
-- Try to open the instrument float window | ||
reaper.Main_OnCommand(instrumentCommandID, 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uses a specific custom command (e.g. from SWS or FX Organizer) to open an instrument’s floating window.
Note: Replace the custom command ID with the correct one for your system or extension.
How are users to figure out what is the "specific command" in question? Also most are unlikely to even notice that "Note", and will just get a non-working script out of the box.
Also "Float instrument on selected track" by MPL already exists.
-- BEHAVIOR | ||
-- ---------------------------------------------------------------------------------------- | ||
-- - Uses a specific custom command (e.g. from SWS or FX Organizer) to open an instrument’s floating window. | ||
-- - If the command fails to detect the instrument window, it opens the normal FX chain window instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script doesn't do that. It toggles the FX browser window if the first selected track does not contain an instrument FX.
No description provided.