Skip to content

fixed coll freq unittest error and added in a note in the dev documentation regarding CamelCase syntax #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fixed coll freq unittest error and added in a note in the dev documentation regarding CamelCase syntax #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
767d5f9
cantherm examples input files fixed
enochd Feb 18, 2014
522116b
reversion of transportData attribute back to mixed-case format
enochd Feb 19, 2014
22acbbf
Merge branch 'master' of github.com:enochd/RMG-Py
enochd Mar 5, 2014
2fbcb44
getCollisionFrequency unittest fix
enochd Mar 5, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions documentation/source/developers/introduction.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,16 @@ Introduction

The :mod:`rmgpy` package contains all of the functionality of RMG.

RMG-Py naming conventions in brief:

* module names are in lowercase
* Class and Exception names start with capital letters (e.g., CamelCase)
* all instances of Classes are mixed-case and begin with lower-case letters (e.g., camelCase)


`Python style guide <http://www.python.org/dev/peps/pep-0008/>`_. In general, refer to this for guidance.


Dependencies
============

Expand Down
4 changes: 2 additions & 2 deletions rmgpy/transportDataTest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ def test_getCollisionFrequency(self):
M = P / constants.R / T
mu = 1.0
omega = self.transport.getCollisionFrequency(T, M, mu)
self.assertAlmostEqual(omega / 3.13010e10, 1.0, 4)

self.assertAlmostEqual(omega / 1.17737e10, 1.0, 4)
def test_pickle(self):
"""
Test that a TransportData object can be pickled and unpickled with no loss of information.
Expand Down