Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AtomicInt NSLock inheritance #2643

Merged
merged 1 commit into from
Feb 15, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Platform/AtomicInt.swift
Original file line number Diff line number Diff line change
@@ -6,6 +6,9 @@
// Copyright © 2018 Krunoslav Zaher. All rights reserved.
//

import CoreFoundation
// This CoreFoundation import can be dropped when this issue is resolved:
// https://github.com/swiftlang/swift-corelibs-foundation/pull/5122
import Foundation

final class AtomicInt: NSLock, @unchecked Sendable {

Unchanged files with check annotations Beta

}
let task = if detached {
Task.detached(priority: priority, operation: operation)

Check warning on line 37 in RxSwift/Traits/PrimitiveSequence/PrimitiveSequence+Concurrency.swift

GitHub Actions / Xcode 15 (iOS)

converting non-sendable function value to '@sendable () async throws -> Void' may introduce data races

Check warning on line 37 in RxSwift/Traits/PrimitiveSequence/PrimitiveSequence+Concurrency.swift

GitHub Actions / Xcode 15 (iOS-Example)

converting non-sendable function value to '@sendable () async throws -> Void' may introduce data races

Check warning on line 37 in RxSwift/Traits/PrimitiveSequence/PrimitiveSequence+Concurrency.swift

GitHub Actions / Xcode 15 (Unix)

converting non-sendable function value to '@sendable () async throws -> Void' may introduce data races

Check warning on line 37 in RxSwift/Traits/PrimitiveSequence/PrimitiveSequence+Concurrency.swift

GitHub Actions / Xcode 15 (Unix)

converting non-sendable function value to '@sendable () async throws -> Void' may introduce data races

Check warning on line 37 in RxSwift/Traits/PrimitiveSequence/PrimitiveSequence+Concurrency.swift

GitHub Actions / Xcode 15 (Unix)

converting non-sendable function value to '@sendable () async throws -> Void' may introduce data races

Check warning on line 37 in RxSwift/Traits/PrimitiveSequence/PrimitiveSequence+Concurrency.swift

GitHub Actions / Xcode 15 (watchOS)

converting non-sendable function value to '@sendable () async throws -> Void' may introduce data races

Check warning on line 37 in RxSwift/Traits/PrimitiveSequence/PrimitiveSequence+Concurrency.swift

GitHub Actions / Xcode 15 (tvOS)

converting non-sendable function value to '@sendable () async throws -> Void' may introduce data races
} else {
Task(priority: priority, operation: operation)

Check warning on line 39 in RxSwift/Traits/PrimitiveSequence/PrimitiveSequence+Concurrency.swift

GitHub Actions / Xcode 15 (iOS)

converting non-sendable function value to '@sendable () async throws -> Void' may introduce data races

Check warning on line 39 in RxSwift/Traits/PrimitiveSequence/PrimitiveSequence+Concurrency.swift

GitHub Actions / Xcode 15 (iOS-Example)

converting non-sendable function value to '@sendable () async throws -> Void' may introduce data races

Check warning on line 39 in RxSwift/Traits/PrimitiveSequence/PrimitiveSequence+Concurrency.swift

GitHub Actions / Xcode 15 (Unix)

converting non-sendable function value to '@sendable () async throws -> Void' may introduce data races

Check warning on line 39 in RxSwift/Traits/PrimitiveSequence/PrimitiveSequence+Concurrency.swift

GitHub Actions / Xcode 15 (Unix)

converting non-sendable function value to '@sendable () async throws -> Void' may introduce data races

Check warning on line 39 in RxSwift/Traits/PrimitiveSequence/PrimitiveSequence+Concurrency.swift

GitHub Actions / Xcode 15 (Unix)

converting non-sendable function value to '@sendable () async throws -> Void' may introduce data races

Check warning on line 39 in RxSwift/Traits/PrimitiveSequence/PrimitiveSequence+Concurrency.swift

GitHub Actions / Xcode 15 (watchOS)

converting non-sendable function value to '@sendable () async throws -> Void' may introduce data races

Check warning on line 39 in RxSwift/Traits/PrimitiveSequence/PrimitiveSequence+Concurrency.swift

GitHub Actions / Xcode 15 (tvOS)

converting non-sendable function value to '@sendable () async throws -> Void' may introduce data races
}
return Disposables.create { task.cancel() }
import RxSwift
/// For more information take a look at `DelegateProxyType`.
open class RxTableViewDelegateProxy

Check warning on line 15 in RxCocoa/iOS/Proxies/RxTableViewDelegateProxy.swift

GitHub Actions / Xcode 15 (iOS)

main actor-isolated class 'RxTableViewDelegateProxy' has different actor isolation from nonisolated superclass 'RxScrollViewDelegateProxy'; this is an error in Swift 6

Check warning on line 15 in RxCocoa/iOS/Proxies/RxTableViewDelegateProxy.swift

GitHub Actions / Xcode 15 (tvOS)

main actor-isolated class 'RxTableViewDelegateProxy' has different actor isolation from nonisolated superclass 'RxScrollViewDelegateProxy'; this is an error in Swift 6
: RxScrollViewDelegateProxy {
/// Typed parent object.
import RxSwift
/// For more information take a look at `DelegateProxyType`.
open class RxCollectionViewDelegateProxy

Check warning on line 15 in RxCocoa/iOS/Proxies/RxCollectionViewDelegateProxy.swift

GitHub Actions / Xcode 15 (iOS)

main actor-isolated class 'RxCollectionViewDelegateProxy' has different actor isolation from nonisolated superclass 'RxScrollViewDelegateProxy'; this is an error in Swift 6

Check warning on line 15 in RxCocoa/iOS/Proxies/RxCollectionViewDelegateProxy.swift

GitHub Actions / Xcode 15 (tvOS)

main actor-isolated class 'RxCollectionViewDelegateProxy' has different actor isolation from nonisolated superclass 'RxScrollViewDelegateProxy'; this is an error in Swift 6
: RxScrollViewDelegateProxy {
/// Typed parent object.
import RxSwift
/// For more information take a look at `DelegateProxyType`.
open class RxTextViewDelegateProxy

Check warning on line 15 in RxCocoa/iOS/Proxies/RxTextViewDelegateProxy.swift

GitHub Actions / Xcode 15 (iOS)

main actor-isolated class 'RxTextViewDelegateProxy' has different actor isolation from nonisolated superclass 'RxScrollViewDelegateProxy'; this is an error in Swift 6

Check warning on line 15 in RxCocoa/iOS/Proxies/RxTextViewDelegateProxy.swift

GitHub Actions / Xcode 15 (tvOS)

main actor-isolated class 'RxTextViewDelegateProxy' has different actor isolation from nonisolated superclass 'RxScrollViewDelegateProxy'; this is an error in Swift 6
: RxScrollViewDelegateProxy {
/// Typed parent object.