Dev.ej/document how to open #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
|
deltork
approved these changes
Feb 26, 2025
joanise
force-pushed
the
dev.ej/document-how-to-open
branch
from
610ecfe to
5ff589d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Goal?
When a single-file HTML is opened from Google Drive, you see the raw HTML instead of the file.
We had discussed two solutions, which we both need:
1- fix how files get opened in Google Drive
2- have the raw HTML show instructions.
This PR implements 2.
Feedback sought?
validation of my help text
Note
When reviewing, the diff looks big because I also fixed the indentation and used .trim and .replace to de-indent the HTML. Looking at the diff with
git diff -wis much nicer, highlighting just the new help text.Priority?
before ICLDC
Tests added?
was already covered, I'm just changing the specific template strings
How to test?
Create an RAS and download the Offline HTML. Upload it to Google Drive, double click on it, and see this:
Confidence?
High for the implementation, medium for the specific instructions I wrote.
Version change?
maybe a patch-level bump