new feature notifications in UI completed with styling and tests #53
Open
ivinayakg wants to merge 9 commits intoRealDevSquad:developfrom
Open
new feature notifications in UI completed with styling and tests #53ivinayakg wants to merge 9 commits intoRealDevSquad:developfrom
ivinayakg wants to merge 9 commits intoRealDevSquad:developfrom
Conversation
pallabez
reviewed
Jul 18, 2022
harshith-venkatesh
left a comment
There was a problem hiding this comment.
Good PR, minor changes are requested
ivinayakg
commented
Jul 20, 2022
harshith-venkatesh
previously approved these changes
Jul 20, 2022
Neha
suggested changes
Jul 20, 2022
Contributor
Neha
left a comment
There was a problem hiding this comment.
Thank you for the PR. Can we discuss this over a call?
Neha
reviewed
Jul 20, 2022
pallabez
reviewed
Jul 26, 2022
756b7de to
7d48924
Compare
Author
Neha
reviewed
Aug 1, 2022
dbe95c2 to
4213a19
Compare
Neha
reviewed
Aug 3, 2022
Contributor
|
@ivinayakg could you please resolve the conflict file? So, that we can merge this branch |
pallabez
reviewed
Oct 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I created a system for notifications throughout the react application.
You get two main things from the main file one is a react component which has to be rendered on the top of the stack with given a prop of timeout(time you want to show a notification for) which defaults to 2000ms. Second is a simple javascript function NotificationHandler which can be called from anywhere from the entire app with a data object which would be:-
The color of the notification would be based upon the "type" of the data object. right now the color would be shown as the background of the notification but as we decide what kind of icon library or solution we would be using then in the future only the icon with the associated color and message from the data will be rendered. The demo of the feature is as below.
Fixes #30
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: