-
Notifications
You must be signed in to change notification settings - Fork 25
Dev to Main #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev to Main #245
Conversation
fix: added emulator tests for all the modules
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
| Missing port range rationale ▹ view | ||
| Inefficient polling with fixed sleep ▹ view | ||
| Inefficient array management in polling loop ▹ view | ||
| Random port generation can cause collisions in parallel execution ▹ view | ||
| Unclear Concurrency Limit Rationale ▹ view | ||
| Extract Parallel Execution Logic ▹ view | ||
| Lack of proper dependency injection ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| verify/main.go | ✅ |
| health-check/main.go | ✅ |
| call-profiles/main.go | ✅ |
| scripts/test.sh | ✅ |
| call-profile/main.go | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
PRs going in #243
Description by Korbit AI
What change is being made?
Refactor Lambda handlers to use an injected Firestore client through a new deps struct, update main handlers to initialize and pass the client, and expand tests and test scaffolding to support integration tests, health checks, and verification flows across multiple modules (with updated test script and environment handling); also broaden .gitignore and minor test scaffolding changes.
Why are these changes being made?
Introduce dependency injection for Firestore to improve testability and reusability, and extend test coverage to exercise integration paths (including Firebase emulator flows) across health-check, call-profile, call-profiles, and verify modules. This enables more robust end-to-end validation while keeping existing code paths intact.