-
Notifications
You must be signed in to change notification settings - Fork 26
Setup Github Workflow #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8abc231
134d0ab
3d1a652
6b42d03
b309b37
c57b30d
a7368c6
894de20
5a10114
378e0ed
0074b64
75042fc
4db836c
704fc5c
79a3330
b4008b2
0e97559
e39e4aa
97249a2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # For more information see: https://docs.github.com/en/actions/learn-github-actions/understanding-github-actions | ||
|
|
||
| name: Continuous Integration | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: ['*'] | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [18.x] | ||
|
|
||
| timeout-minutes: 10 | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| cache: 'yarn' | ||
| - run: yarn | ||
prakashchoudhary07 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - run: yarn prettier:check | ||
| - run: yarn test:coverage | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial Consider uploading coverage reports. The workflow runs test coverage but doesn't upload or report the results anywhere. Consider integrating with a coverage service like Codecov or Coveralls for visibility into test coverage trends. Example step to add after test coverage: - name: Upload coverage reports
uses: codecov/codecov-action@v3
with:
files: ./coverage/coverage-final.json
fail_ci_if_error: false🤖 Prompt for AI Agents |
||
| - run: yarn build | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,11 @@ | ||
| const nextJest = require('next/jest'); | ||
|
|
||
| const createJestConfig = nextJest({ | ||
| dir: './', | ||
| }); | ||
| const createJestConfig = nextJest({ dir: './' }); | ||
|
|
||
| const customJestConfig = { | ||
| setupFilesAfterEnv: ['<rootDir>/jest.setup.js'], | ||
| moduleDirectories: ['node_modules', '<rootDir>/'], | ||
| testEnvironment: 'jest-environment-jsdom', | ||
| testEnvironmentOptions: { | ||
| customExportConditions: [''], | ||
| }, | ||
| }; | ||
|
|
||
| module.exports = createJestConfig(customJestConfig); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,4 +40,4 @@ | |
| .newMemberSectionLoadMore__button:disabled:hover { | ||
| color: #020617; | ||
| background-color: #e2e8f0; | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -145,7 +145,6 @@ | |
| } | ||
| } | ||
|
|
||
|
|
||
| @media only screen and (max-width: 767px) { | ||
| .content { | ||
| margin-top: 1rem; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Consider pinning the Node version more specifically.
The workflow uses
18.xwhilepackage.jsonspecifies18.20.8via Volta. Using a more specific version in CI ensures consistency with local development.Apply this diff to align with the Volta configuration:
📝 Committable suggestion
🤖 Prompt for AI Agents