Skip to content

Conversation

@Hariom01010
Copy link
Contributor

Date: 2 Jan 2026

Developer Name: @Hariom01010


Issues Resolved

Closes #230

PRs going in Sync

Description

  • Enhance currently existing modal used to create or edit a todo to support a view mode which shows todo details in read only mode if user doesn't have edit acess for the todo.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1
proof.of.working.mp4

Test Coverage

Screenshot 1 Screenshot 2026-01-02 020130

Additional Notes

* feat(view-todo-modal):

- add component to show todo details in read only mode with edit and
  close button.
- move updateTask mutation to a separate hook
- renamed create-edit-todo-dialog to todo-dialog

* feat(view-modal):add type for modal state

* feat(view-todo-modal): fix ESLint warning in TodoDialog useEffect hook

* feat(view-todo-modal): remove view modal component and add view mode support in createEditTodoForm

* feat(view-todo-modal): fix build issues

* feat(view-todo-modal): add constant file for todo constants
- update filename from create-todo-form to todo-form

* feat(view-todo-modal): update constant file name and move type to todo-dialog.tsx

* feat(view-todo-modal): update imports

* feat(view-todo-modal): remove unnecessary check for form submit

* feat(view-todo-modal): declare constant in todo-dialog and remove todo.constants.ts file
@Hariom01010 Hariom01010 self-assigned this Jan 1, 2026
@Hariom01010 Hariom01010 added enhancement Improving something existing feature task A big ticket item that needs to come up as a feature labels Jan 1, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 1, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yesyash yesyash merged commit 0bbd412 into main Jan 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improving something existing feature task A big ticket item that needs to come up as a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants