feat: add review step for new stepper [Onboarding-Form] #1087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Hardcoded Storage Keys ▹ view | |
|
Misspelled Platform Name ▹ view | |
|
Sequential Property Names Instead of Data Structure ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| app/constants/new-join-form.js | ✅ |
| app/components/new-join-steps/new-step-six.js | ✅ |
| app/components/new-stepper.js | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Deploying www-rds with
|
| Latest commit: |
c3fd942
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://24166e72.www-rds.pages.dev |
| Branch Preview URL: | https://feat-review-step.www-rds.pages.dev |
MayankBansal12
force-pushed
the
feat/new-step-3
branch
from
638d089 to
14566a3
Compare
MayankBansal12
changed the title
MayankBansal12
force-pushed
the
feat/review-step
branch
from
033aea3 to
ec0cbfc
Compare
10 tasks
| export default class NewStepperComponent extends Component { | ||
| MIN_STEP = 0; | ||
| MAX_STEP = 6; | ||
| applicationId = '4gchuf690'; |
Contributor
There was a problem hiding this comment.
What is this ID hardcoded?
prakashchoudhary07
approved these changes
Nov 11, 2025
Contributor
prakashchoudhary07
left a comment
prakashchoudhary07
left a comment
There was a problem hiding this comment.
As discussed, @MayankBansal12 will make the changes in the refactor PR
prakashchoudhary07
pushed a commit
that referenced
this pull request
Nov 11, 2025
…ing-Form] (#1086) * feat: add new step for social links * feat: add snew step four for social links * feat: add new step fivve for stepper * fix: styling for selectt in new step five * refactor: replace hardcoded storage keys with constants * feat: add review step for new stepper [Onboarding-Form] (#1087) * feat: add review step for new stepper * feat: add thank you screen for new stepper * refactor: use structure for step data and replace hardcoded storage keys * refactor: use getter func for review step button
prakashchoudhary07
pushed a commit
that referenced
this pull request
Nov 11, 2025
…1084) * feat: add new step two for introduction * feat: add step three for interests * feat: add base step class to handle input validation and local storage sync * fix: postIntialization in new step one * fix: grid styling for step two and three * refactor: remove redundant max words * fix: lint issue and form headings * refactor: use constant for storage keys * feat: add new step four and five for social links and whyRds [Onboarding-Form] (#1086) * feat: add new step for social links * feat: add snew step four for social links * feat: add new step fivve for stepper * fix: styling for selectt in new step five * refactor: replace hardcoded storage keys with constants * feat: add review step for new stepper [Onboarding-Form] (#1087) * feat: add review step for new stepper * feat: add thank you screen for new stepper * refactor: use structure for step data and replace hardcoded storage keys * refactor: use getter func for review step button
prakashchoudhary07
pushed a commit
that referenced
this pull request
Nov 11, 2025
* feat: add step one for image upload and personal details * fix: styling for form header * fix: styling for image box and input boxes * feat: add prev and next stepper buttons * fix: incorrect data testt for stepper buttons * feat: add base step component for all new steps * fix: input validation in new step one * refactor: improve progress calculation and update header text * refactor: improve step navigation * fix: image upload preview and update storage keys * refactor: use try catch in local storage actions * refactor: improve accessibility in new step one * refactor: enhance image upload and new stepper error handling * refactor: validation for fields in new stepper and enhance button layout * feat: add new step 2 and 3 for intro and interests [Onboarding-Form] (#1084) * feat: add new step two for introduction * feat: add step three for interests * feat: add base step class to handle input validation and local storage sync * fix: postIntialization in new step one * fix: grid styling for step two and three * refactor: remove redundant max words * fix: lint issue and form headings * refactor: use constant for storage keys * feat: add new step four and five for social links and whyRds [Onboarding-Form] (#1086) * feat: add new step for social links * feat: add snew step four for social links * feat: add new step fivve for stepper * fix: styling for selectt in new step five * refactor: replace hardcoded storage keys with constants * feat: add review step for new stepper [Onboarding-Form] (#1087) * feat: add review step for new stepper * feat: add thank you screen for new stepper * refactor: use structure for step data and replace hardcoded storage keys * refactor: use getter func for review step button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 05-11-25
Developer Name: @MayankBansal12
Issue Ticket Number:-
Description:
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
Tested in staging?
Add relevant Screenshot below ( e.g test coverage etc. )
screencast
review.online-video-cutter.com.mp4
thank-you.mp4