-
Notifications
You must be signed in to change notification settings - Fork 153
style: add styling for application detail page #1136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying www-rds with
|
| Latest commit: |
690e39e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b399c84c.www-rds.pages.dev |
| Branch Preview URL: | https://styling-application-detail.www-rds.pages.dev |
WalkthroughThree CSS-related changes introduce styling for an application detail page and expand button utilities. A new CSS module is created with comprehensive layout and responsive styles, imported globally, while an existing button module gains a new extra-small button variant. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@app/styles/application-detail.module.css`:
- Around line 119-136: The CSS uses the token --color-lightgray in
.social-link-pill (and other places) which likely mismatches the project's
--color-lightgrey naming; either rename the token usage to --color-lightgrey
where .social-link-pill and any other rules use --color-lightgray, or add a new
--color-lightgray token to the design tokens; update all occurrences to be
consistent (search for --color-lightgray and replace or add the token) so
background/border values don't fallback to defaults.
In `@app/styles/button.module.css`:
- Around line 44-49: The .btn--xs touch target is too small for coarse pointers;
add a touch-friendly override using a media query for pointer: coarse (or hover:
none) to increase the minimum tappable size—e.g., raise min-height/min-width to
at least 44px (≈2.75rem) or adjust height accordingly—so update the .btn--xs
rule set by adding a `@media` (pointer: coarse) block that targets .btn--xs and
sets a larger min-height (and min-width if needed) to ensure comfortable touch
targets on mobile.
859a65f to
70b2393
Compare
Date: 19-01-26
Developer Name: @MayankBansal12
Issue Ticket Number:-
Description:
feat PR: feat: add application detail page #1130
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
Tested in staging?
Add relevant Screenshot below ( e.g test coverage etc. )
demo
Screencast.from.2026-01-19.04-40-56.mp4
Screencast.from.2026-01-19.04-58-52.mp4