Device ID for OWL1 on new firmware #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingdynasty
reviewed
Sep 13, 2020
This is explained in linked issue to OwlProgram repo. But the general goals here are to allow building patches that would either:
We could keep using first option in web patcher, but suggest users with legacy FW to switch to new FW and their patches would still have correct behavior. And second option would be used by anyone building patches offline with new FW. Adding FW ID looks like a cleaner solution for first option. But it seems to be more invasive - I guess it would require using a different program vector version? |
|
This was done without merging current PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FW side update for RebelTechnology/OwlProgram#70