Enroll in notifs for upgrading #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RitamNandi
temporarily deployed
to
supabase_test
GitHub Actions
Inactive
RitamNandi
temporarily deployed
to
supabase_test
GitHub Actions
Inactive
RitamNandi
temporarily deployed
to
supabase_test
GitHub Actions
Inactive
Timothy-Gonzalez
temporarily deployed
to
supabase_test
GitHub Actions
Inactive
Timothy-Gonzalez
requested changes
Sep 15, 2025
Collaborator
Timothy-Gonzalez
left a comment
Timothy-Gonzalez
left a comment
There was a problem hiding this comment.
Core logic looks good but let's reduce the number requests we make to 2 instead of n*2
RitamNandi
temporarily deployed
to
supabase_test
GitHub Actions
Inactive
Timothy-Gonzalez
approved these changes
Sep 15, 2025
Collaborator
Timothy-Gonzalez
left a comment
Timothy-Gonzalez
left a comment
There was a problem hiding this comment.
Perfect, thanks! Ideally we would have tests but that's different pr problem - this code won't change things from working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
promotion function takes in the day that the person is getting promoted on
Enroll anyone who got upgraded on a day to a topic for upgrades for that day
After the events for a day conclude, admins can go on the admin site and send a generic notification message to everyone who got a tier upgrade. Probably something like "You got a tier upgrade! Open the app to check your current tier" or something to tell them that they can go redeem a prize. Needs to be generic across tiers, won't have specific notifications for upgrades for certain tiers
Please review so hopefully I didn't break leaderboard