Leaderboard updates #262
Merged
Leaderboard updates #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandani4136
temporarily deployed
to
supabase_test
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the leaderboard system with updates to sorting, tier filtering, and submission management. The changes improve tie-breaking consistency and add functionality to prevent duplicate submissions.
- Enhanced sorting with consistent tie-breaking using displayName
- Removed TIER4 user filtering to include all user tiers
- Added submission status checking to prevent duplicate leaderboard submissions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/services/leaderboard/leaderboard-utils.ts | Updated sorting logic, removed tier filtering, and added submission existence checking |
| src/services/leaderboard/leaderboard-schema.ts | Added new validation schemas for submission checking and optional user promotion list |
| src/services/leaderboard/leaderboard-router.ts | Added submission status endpoint and duplicate submission prevention logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
anandani4136
temporarily deployed
to
supabase_test
GitHub Actions
Inactive
anandani4136
temporarily deployed
to
supabase_test
GitHub Actions
Inactive
Bahl-Aryan
approved these changes
Sep 14, 2025
Contributor
Bahl-Aryan
left a comment
Bahl-Aryan
left a comment
There was a problem hiding this comment.
theres probably more nits and some rendundancy issues (in leaderboard utils), but LGTM just want to unblock
Bahl-Aryan
temporarily deployed
to
supabase_test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.