Skip to content

Conversation

@J164
Copy link
Member

@J164 J164 commented Sep 14, 2025

No description provided.

@J164 J164 requested review from a team and Copilot September 14, 2025 17:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the /assignments route to return all shift assignments instead of assignments for a specific shift. The change removes the shift ID parameter requirement and modifies the endpoint to fetch all assignments across all shifts.

  • Removed shift ID parameter from the route path and validation logic
  • Updated database query to fetch all shift assignments instead of filtering by shift ID
  • Modified test case to reflect the new endpoint behavior

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/services/shifts/shifts-router.ts Updated route from /:shiftId/assignments to /assignments, removed shift ID validation and filtering
src/services/shifts/shifts-router.test.ts Updated test to use new endpoint path without shift ID parameter

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@anandani4136 anandani4136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@J164 J164 merged commit 37bd4a1 into main Sep 14, 2025
5 checks passed
@J164 J164 deleted the update-assignments-route branch September 14, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants