Fix mailing list #120
Merged
Fix mailing list #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the mailing list functionality by updating the API endpoint and data structure for retrieving subscription lists. The change simplifies the data structure from complex objects to a simple array of strings.
- Added new
/subscription/listsAPI endpoint that returns a simplified string array - Updated the admin interface to use the new endpoint and simplified data structure
- Refactored the UI component to work with string arrays instead of objects
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| shared/src/api/types.ts | Added new API route /subscription/lists with simplified response type |
| apps/admin/src/routes/pages/Massmailer.tsx | Updated to use new endpoint and simplified data structure for mailing lists |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Deploying rp-web-hype with
|
| Latest commit: |
a25ee7e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://199f04d8.rp-web-hype.pages.dev |
| Branch Preview URL: | https://fix-mailing-lists.rp-web-hype.pages.dev |
Deploying rp-web-admin with
|
| Latest commit: |
a25ee7e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://18728bce.rp-web-admin.pages.dev |
| Branch Preview URL: | https://fix-mailing-lists.rp-web-admin.pages.dev |
Deploying rp-web-sponsor with
|
| Latest commit: |
a25ee7e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dc57bb1f.rp-web-sponsor.pages.dev |
| Branch Preview URL: | https://fix-mailing-lists.rp-web-sponsor.pages.dev |
Deploying rp-web-site with
|
| Latest commit: |
a25ee7e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7f2126ef.rp-web-site.pages.dev |
| Branch Preview URL: | https://fix-mailing-lists.rp-web-site.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.