Skip to content

[Snyk] Security upgrade werkzeug from 2.2.3 to 3.1.4 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RemyLoveLogicAI wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade werkzeug from 2.2.3 to 3.1.4 #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,5 @@ google-auth<3,>=2
screeninfo
uiautomation
dashscope
groq
groq
werkzeug>=3.1.4 # not directly required, pinned by Snyk to avoid a vulnerability

@gemini-code-assist gemini-code-assist Bot Dec 3, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change pins werkzeug to version 3.1.4 or higher to fix a security vulnerability. However, this is a major version upgrade from the previously used 2.x version, which introduces significant breaking changes. Directly pinning a transitive dependency like this, especially across a major version, is highly risky and can break your application if other dependencies rely on werkzeug 2.x (e.g., older versions of Flask).

It is strongly recommended to identify which direct dependency in your project uses werkzeug and upgrade that parent dependency to a version that uses a non-vulnerable version of werkzeug. If that's not feasible, this change requires extensive testing to ensure the application still functions correctly. The numerous dependency warnings in the PR description already indicate a fragile environment, and this change could exacerbate the issues.

@gemini-code-assist gemini-code-assist Bot Dec 3, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This file is missing a newline character at the end. It's a good practice for text files to end with one to prevent potential issues with some tools and file manipulations (e.g., cat) and to follow POSIX conventions. I've suggested adding one.

werkzeug>=3.1.4 # not directly required, pinned by Snyk to avoid a vulnerability