forked from Skyvern-AI/skyvern
-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade python from 3.11-slim-bookworm to 3.14.1-slim-bookworm #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RemyLoveLogicAI
wants to merge
1
commit into
main
Choose a base branch
from
snyk-fix-0f164c7d9bf2fea82a0059e2ab11844d
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -7,7 +7,7 @@ COPY ./pyproject.toml /tmp/pyproject.toml | |||||
| COPY ./poetry.lock /tmp/poetry.lock | ||||||
| RUN poetry export -f requirements.txt --output requirements.txt --without-hashes | ||||||
|
|
||||||
| FROM python:3.11-slim-bookworm | ||||||
| FROM python:3.14.1-slim-bookworm | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P1: The final stage now runs on Python 3.14 even though the project declares support only for Python <3.12; installing dependencies or running the app under this image will violate the declared interpreter constraint and break the build. Prompt for AI agents
Suggested change
|
||||||
| WORKDIR /app | ||||||
| COPY --from=requirements-stage /tmp/requirements.txt /app/requirements.txt | ||||||
| RUN pip install --no-cache-dir --upgrade -r requirements.txt | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suggested base image
python:3.14.1-slim-bookwormis invalid and will break your build.pyproject.tomlspecifiespython = "^3.11,<3.12", meaning your project is designed for Python 3.11. Upgrading to a different minor version of Python is a significant breaking change that is not intended by this security patch. Yourruffconfiguration is also targetingpy311.To fix the security vulnerabilities while maintaining compatibility, you should update to the latest patch release of Python 3.11. I suggest using
python:3.11.9-slim-bookworm, which is the latest security patch for the 3.11 series.