fix(graphql-request): use same version in all packages #1623
+31
−1,074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThe changes update Jest configuration to better handle mixed JavaScript and TypeScript files, specifically ensuring transformation of certain ES modules. Babel configurations and related dependencies are removed from multiple packages, simplifying the build and test setup. The Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App
participant globalThis
participant ethers
User->>App: Calls getProvider()
App->>globalThis: Checks for ethereum
alt ethereum exists
App->>ethers: Create new Web3Provider(globalThis.ethereum)
App-->>User: Returns provider
else ethereum missing
App-->>User: Throws error "Ethereum provider not found"
end
Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
alexandre-abrioux
force-pushed
the
fixup-graphql-request
branch
from
a6f12d9 to
d999342
Compare
Comment on lines
-31
to
33
| if (typeof window !== 'undefined' && 'ethereum' in window) { | ||
| return new ethers.providers.Web3Provider((window as any).ethereum); | ||
| if ('ethereum' in globalThis) { | ||
| return new ethers.providers.Web3Provider((globalThis as any).ethereum); | ||
| } |
There was a problem hiding this comment.
Without this change, we would get the following error during build:
✖ @requestnetwork/payment-processor:build
$ tsc -b tsconfig.build.json
src/payment/utils.ts(31,14): error TS2304: Cannot find name 'window'.I'm guessing it worked before because graphql-request v6 was declaring a window type globally.
alexandre-abrioux
force-pushed
the
fixup-graphql-request
branch
from
a9e7172 to
175ead6
Compare
github-actions
bot
requested review from
bassgeta,
kevindavee,
leoslr and
MantisClone
MantisClone
approved these changes
May 20, 2025
leoslr
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Use the same version of
graphql-requestin all packages.7.1.2version inthegraph-data-accessThis PR removes all Babel config used in Jest that is not needed anymore, and centralizes the exception to transform the
graphql-requestwithts-jest.Summary by CodeRabbit
Bug Fixes
Chores
graphql-requestdependency.