fix(graphql-request): use same version in all packages #1623
Conversation
WalkthroughThe changes update Jest configuration to better handle mixed JavaScript and TypeScript files, specifically ensuring transformation of certain ES modules. Babel configurations and related dependencies are removed from multiple packages, simplifying the build and test setup. The Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App
participant globalThis
participant ethers
User->>App: Calls getProvider()
App->>globalThis: Checks for ethereum
alt ethereum exists
App->>ethers: Create new Web3Provider(globalThis.ethereum)
App-->>User: Returns provider
else ethereum missing
App-->>User: Throws error "Ethereum provider not found"
end
Possibly related PRs
Suggested reviewers
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
💤 Files with no reviewable changes (5)
🔇 Additional comments (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
alexandre-abrioux
force-pushed
the
fixup-graphql-request
branch
from
a6f12d9 to
d999342
Compare
| if (typeof window !== 'undefined' && 'ethereum' in window) { | ||
| return new ethers.providers.Web3Provider((window as any).ethereum); | ||
| if ('ethereum' in globalThis) { | ||
| return new ethers.providers.Web3Provider((globalThis as any).ethereum); | ||
| } |
There was a problem hiding this comment.
Without this change, we would get the following error during build:
✖ @requestnetwork/payment-processor:build
$ tsc -b tsconfig.build.json
src/payment/utils.ts(31,14): error TS2304: Cannot find name 'window'.I'm guessing it worked before because graphql-request v6 was declaring a window type globally.
alexandre-abrioux
force-pushed
the
fixup-graphql-request
branch
from
a9e7172 to
175ead6
Compare
github-actions
bot
requested review from
bassgeta,
kevindavee,
leoslr and
MantisClone
Description of the changes
Use the same version of
graphql-requestin all packages.7.1.2version inthegraph-data-accessThis PR removes all Babel config used in Jest that is not needed anymore, and centralizes the exception to transform the
graphql-requestwithts-jest.Summary by CodeRabbit
Bug Fixes
Chores
graphql-requestdependency.