Skip to content

Code quality fix - Performance - Method invokes inefficient Number constructor; use static valueOf instead. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
faisal-hameed wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Code quality fix - Performance - Method invokes inefficient Number constructor; use static valueOf instead. #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/cloudhopper/smpp/pdu/Pdu.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public void removeCommandLength() {
}

public void setCommandLength(int value) {
this.commandLength = new Integer(value);
this.commandLength = Integer.valueOf(value);
}

public int getCommandLength() {
Expand Down Expand Up @@ -124,7 +124,7 @@ public void removeSequenceNumber() {
}

public void setSequenceNumber(int value) {
this.sequenceNumber = new Integer(value);
this.sequenceNumber = Integer.valueOf(value);
}

public int getSequenceNumber() {
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/cloudhopper/smpp/transcoder/DefaultPduTranscoderContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public String lookupResultMessage(int commandStatus) {
resultMessage = overrideContext.lookupResultMessage(commandStatus);
}
if (resultMessage == null) {
resultMessage = SmppConstants.STATUS_MESSAGE_MAP.get(new Integer(commandStatus));
resultMessage = SmppConstants.STATUS_MESSAGE_MAP.get(Integer.valueOf(commandStatus));
}
return resultMessage;
}
Expand All @@ -62,7 +62,7 @@ public String lookupTlvTagName(short tag) {
tagName = overrideContext.lookupTlvTagName(tag);
}
if (tagName == null) {
tagName = SmppConstants.TAG_NAME_MAP.get(new Short(tag));
tagName = SmppConstants.TAG_NAME_MAP.get(Short.valueOf(tag));
}
return tagName;
}
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/cloudhopper/smpp/util/ConcurrentCommandStatusCounter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public ConcurrentCommandStatusCounter copy() {
}

public int get(int commandStatus) {
Integer key = new Integer(commandStatus);
Integer key = Integer.valueOf(commandStatus);
AtomicInteger val = map.get(key);
if (val == null) {
return -1;
Expand All @@ -61,7 +61,7 @@ public int get(int commandStatus) {
}

public int incrementAndGet(int commandStatus) {
Integer key = new Integer(commandStatus);
Integer key = Integer.valueOf(commandStatus);
AtomicInteger val = map.get(key);
if (val == null) {
val = new AtomicInteger(0);
Expand Down