Skip to content

General code quality fix-2 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
faisal-hameed wants to merge 1 commit into
base: master
Choose a base branch
from
Open

General code quality fix-2 #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/com/cloudhopper/smpp/pdu/Pdu.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@
import com.cloudhopper.smpp.tlv.Tlv;
import com.cloudhopper.smpp.transcoder.PduTranscoderContext;
import com.cloudhopper.smpp.util.ChannelBufferUtil;

import java.util.ArrayList;
import java.util.List;

import org.jboss.netty.buffer.ChannelBuffer;

public abstract class Pdu {
Expand Down Expand Up @@ -147,7 +150,7 @@ public int getOptionalParameterCount() {
* added, this will return null.
* @return Null if no parameters added yet, or the list of optional parameters.
*/
public ArrayList<Tlv> getOptionalParameters() {
public List<Tlv> getOptionalParameters() {
return this.optionalParameters;
}

Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/cloudhopper/smpp/type/NotEnoughDataInBufferException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
public class NotEnoughDataInBufferException extends RecoverablePduException {
static final long serialVersionUID = 1L;

private int available;
private int expected;
private final int available;
private final int expected;

/**
* Constructs an instance of <code>AtNotEnoughDataInBufferException</code>
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/cloudhopper/smpp/type/SmppProcessingException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
public class SmppProcessingException extends Exception {
static final long serialVersionUID = 1L;

private int errorCode;
private final int errorCode;

public SmppProcessingException(int errorCode) {
this(errorCode, null);
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/cloudhopper/smpp/util/DeliveryReceipt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ static private DateTime parseDateTimeHelper(String value, DateTimeZone zone) {
}

static public void findFieldAndAddToTreeMap(String normalizedText,
String field, TreeMap<Integer, String> fieldsByStartPos) {
String field, Map<Integer, String> fieldsByStartPos) {
int startPos = normalizedText.indexOf(field);
// logger.debug("Found field " + field + " at startPos " + startPos);
if (startPos >= 0) {
Expand Down