Implement main.dol replacements#94
Merged
Merged
Conversation
also changes the folder content collection code to use a single loop + a dynamic array rather than two loops to avoid having to duplicate the checks in two loops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #81. Tested on Dolphin. This works by essentially overwriting the previously loaded main game DOL at 0x8090000 with the main.dol on the SD card.
This also changes the folder contents collection code to allocate the entries in a dynamic array first and then copy them into MEM1 (this will still not over-allocate MEM1 space as the previous version intended).
My reasoning for this is that while implementing main.dol replacements I initially only added the
strcmp("main.dol")check in the second loop and not in the first one, and that resulted in a wrong count/corruption later on which was hard to debug, so IMO this is kinda error prone having to duplicate the checks in two places.Although if thats controversial I can revert this and just have the strcmp() in both loops, it's not required for the main purpose of this PR