fix: make RemoteInstaller.Install return error instead of silently returning nil#5
Open
Ricardo-M-L wants to merge 1 commit into
Open
fix: make RemoteInstaller.Install return error instead of silently returning nil#5Ricardo-M-L wants to merge 1 commit into
Ricardo-M-L wants to merge 1 commit into
Conversation
…turning nil RemoteInstaller.Install was a no-op that returned (nil, nil), which silently masks programming errors when it's called directly instead of InstallRemote(). This adds an explicit error to catch such misuse. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RemoteInstaller.Installwhich was returning(nil, nil)- a silent failure that masks programming errorsWhat
RemoteInstaller.Installwas a no-op that returned(nil, nil). This is problematic because:RemoteInstaller.Installinstead ofInstallRemote, the error goes undetectedInstallerinterface contract expects either a valid*Resultor an errorHow
Changed the method to return
fmt.Errorf("RemoteInstaller.Install should not be called directly - use InstallRemote instead")and added the necessaryfmtimport.Testing
go build ./...passesgo vet ./internal/installer/passesCloses #XXX
🤖 Generated with Claude Code