fix: add cleanup(ip) to connRateLimiter to prevent memory leak - #206
Merged
levibliz merged 1 commit intoJul 28, 2026
Merged
Conversation
Every unique IP that connected created a windows Map entry that was never deleted, causing unbounded memory growth in long-running deployments with frequently changing mobile IPs. - Add cleanup(ip) method to createConnRateLimiter that deletes the IP's entry from the windows Map - Call connRateLimiter.cleanup(ws._trackedIp) in the ws close handler in server.js inside the existing trackedIp guard - Add unit tests asserting fresh window after cleanup, no-op for unknown IPs, and that cleanup does not throw Fixes memory leak in conn-rate-limiter windows Map.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every unique IP that connected created a windows Map entry that was never deleted, causing unbounded memory growth in long-running deployments with frequently changing mobile IPs.
Closes #169
Fixes memory leak in conn-rate-limiter windows Map.