Skip to content

fix(kernel): sync all agent.toml fields to DB on restart #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaberjaber23 merged 1 commit into from
Apr 29, 2026
Merged

fix(kernel): sync all agent.toml fields to DB on restart #1118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions crates/openfang-kernel/src/kernel.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1196,7 +1196,11 @@ impl OpenFangKernel {
&toml_str,
) {
Ok(disk_manifest) => {
// Compare key fields to detect changes
// Compare key fields to detect changes.
// IMPORTANT: keep this list in sync with AgentManifest
// fields that users may legitimately edit in agent.toml.
// Missing a field here means changes to it are silently
// ignored until the agent is deleted and recreated.
let changed = disk_manifest.name != entry.manifest.name
|| disk_manifest.description
!= entry.manifest.description
Expand All @@ -1214,7 +1218,19 @@ impl OpenFangKernel {
!= entry.manifest.tool_blocklist
|| disk_manifest.skills != entry.manifest.skills
|| disk_manifest.mcp_servers
!= entry.manifest.mcp_servers;
!= entry.manifest.mcp_servers
// Fields previously missing from this check (#1087):
// Only compare workspace when the TOML explicitly sets
// one, so the kernel-assigned default path in the DB
// is not overwritten for agents that omit the field.
|| disk_manifest.workspace.as_ref().is_some_and(
|w| Some(w) != entry.manifest.workspace.as_ref(),
)
|| disk_manifest.schedule != entry.manifest.schedule
|| disk_manifest.autonomous != entry.manifest.autonomous
|| disk_manifest.resources != entry.manifest.resources
|| disk_manifest.exec_policy
!= entry.manifest.exec_policy;
if changed {
info!(
agent = %name,
Expand Down
6 changes: 3 additions & 3 deletions crates/openfang-types/src/agent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ impl Default for ModelRoutingConfig {
}

/// Autonomous agent configuration — guardrails for 24/7 agents.
#[derive(Debug, Clone, Serialize, Deserialize)]
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
#[serde(default)]
pub struct AutonomousConfig {
/// Cron expression for quiet hours (e.g., "0 22 * * *" to "0 6 * * *").
Expand Down Expand Up @@ -223,7 +223,7 @@ impl AgentMode {
}

/// How an agent is scheduled to run.
#[derive(Debug, Clone, Default, Serialize, Deserialize)]
#[derive(Debug, Clone, Default, PartialEq, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum ScheduleMode {
/// Agent wakes up when a message/event arrives (default).
Expand All @@ -245,7 +245,7 @@ fn default_check_interval() -> u64 {
}

/// Resource limits for an agent.
#[derive(Debug, Clone, Serialize, Deserialize)]
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
#[serde(default)]
pub struct ResourceQuota {
/// Maximum WASM memory in bytes.
Expand Down
2 changes: 1 addition & 1 deletion crates/openfang-types/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,7 +858,7 @@ pub enum ExecSecurityMode {
}

/// Shell/exec security policy.
#[derive(Debug, Clone, Serialize, Deserialize)]
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
#[serde(default)]
pub struct ExecPolicy {
/// Security mode: "deny" blocks all, "allowlist" only allows listed,
Expand Down
Loading