Upgrade to Kubernetes 1.35 compatibility #36
+1,202
−573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update Go version from 1.21 to 1.25.0 (required by k8s.io/api v0.35.0) - Upgrade k8s.io/api, k8s.io/apimachinery, k8s.io/client-go from v0.29.2 to v0.35.0 - Upgrade sigs.k8s.io/controller-runtime from v0.17.3 to v0.19.0 - Upgrade istio.io/api and istio.io/client-go from v1.17.x to v1.24.0 - Update controller-gen from v0.9.2 to v0.16.0 - Update kustomize from v3.8.7 to v5.4.0 - Update kind from v0.18.0 to v0.24.0 - Update istioctl from v1.17.2 to v1.24.0 - Update golangci-lint config to v2 format - Fix TypedEventHandler generics for controller-runtime v0.19 - Fix format string warnings in dynamicenv_controller.go - Update CI matrix: add k8s 1.35, keep 1.29/1.25, remove 1.21/1.23 - Update Dockerfile to golang:1.25 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Upgrade controller-tools from v0.16.0 to v0.20.0 to fix build failure in CI. The v0.16.0 version has an incompatible golang.org/x/tools dependency that fails to compile with Go 1.25. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Upgrade crd-ref-docs from v0.0.9 to v0.2.0 to fix build failure in CI. The v0.0.9 version has an incompatible golang.org/x/tools dependency that fails to compile with Go 1.25. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Run `make pre-merge` to regenerate CRD reference documentation and helm CRD templates with updated controller-gen v0.20.0 output. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Update golangci-lint from 1.64.5 to 2.8.0 in .tool-versions - Exclude QF* and ST* staticcheck rules in .golangci.yaml to maintain compatibility with existing code style (these are documentation/style suggestions, not errors) golangci-lint v1.x was built with Go 1.24 which cannot lint Go 1.25 code. v2.4.0+ supports Go 1.25. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Breaking Changes Addressed
pkg/watches/enqueue_annotations.gofor controller-runtime v0.19 TypedEventHandler generics APIinternal/controller/dynamicenv_controller.gofor Go 1.25 vet strictness.golangci.yamlto v2 format for newer golangci-lintTest plan
make buildpassesgo test ./...passesgolangci-lint runpassesmake docker-buildpasses🤖 Generated with Claude Code