TIS-420 Prevent loading multiple rows #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkaminsk
changed the title
Daniel-Shai
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fetch order entity from database, we use magento collection with filters for
entity_id(primary key) andincrement id(magento public order number) - it's impossible to fetch more than one order for this combination.Magento/AdobeCommerce (AC) has a validation to prevent adding two items to collections with same primary key (in this case it's
entity_idfromsales_ordertable)The issue is related to additional left join added to 3rd party extension. When order has more than one order item, it's duplicating results in the collection.
Solution is to set
limitfor db query and fetch only one item.