Skip to content

Add Admin_Resource on Admin controllers + Add escaper on templates + Add bind on fetchRow to avoid risk of SQL Injection #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bretin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Admin_Resource on Admin controllers + Add escaper on templates + Add bind on fetchRow to avoid risk of SQL Injection #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Controller/Adminhtml/Riskified/Masssend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

class Masssend extends \Magento\Backend\App\Action
{
public const ADMIN_RESOURCE = 'Magento_Sales::sales_order';

/**
* @var OrderApi
*/
Expand Down
2 changes: 2 additions & 0 deletions Controller/Adminhtml/Riskified/Send.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

class Send extends \Magento\Backend\App\Action
{
public const ADMIN_RESOURCE = 'Magento_Sales::sales_order';

/**
* @var OrderApi
*/
Expand Down
6 changes: 5 additions & 1 deletion Model/Observer/UpdateOrderState.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,11 @@ private function saveStatusBeforeHold($newState, $order)
\Magento\Framework\App\ResourceConnection::DEFAULT_CONNECTION
);
$tableOrderStatuses = $connection->getTableName('sales_order_status_state');
$result = $connection->fetchRow('SELECT state FROM `' . $tableOrderStatuses . '` WHERE status="' . $status . '"');

$result = $connection->fetchRow(
'SELECT state FROM `' . $tableOrderStatuses . '` WHERE status = ?',
[$status]
);
$state = $result['state'];

$order->setHoldBeforeState($state);
Expand Down
18 changes: 12 additions & 6 deletions view/frontend/templates/riskified_js.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,26 @@
<?php if ($block->isEnabled()) : ?>
<?php
/**
* @var \Riskified\Decider\Block\Js $block
* @var \Magento\Framework\Escaper $escaper
*/
?>
<?php if ($block->isEnabled()): ?>
<script type="text/javascript">
function riskifiedBeaconLoad() {
jQuery.ajax(
"<?php echo $block->getUrl("decider/response/session"); ?>", {
"<?= $escaper->escapeUrl($block->getUrl('decider/response/session')); ?>", {
success : function(response) {
var session_id = response.session_id;

if(!session_id) {
return false;
}

var store_domain = "<?php echo $block->getShopDomain() ?>";
var version = "<?php echo $block->getExtensionVersion() ?>";
var store_domain = "<?= $escaper->escapeJs($block->getShopDomain()) ?>";
var version = "<?= $escaper->escapeJs($block->getExtensionVersion()) ?>";

var url = ('https:' == document.location.protocol ? 'https://' : 'http://')
+ "<?php echo $block->getConfigBeaconUrl()?>?shop=" + store_domain
+ "<?= $escaper->escapeUrl($block->getConfigBeaconUrl()) ?>?shop=" + store_domain
+ "&sid=" + session_id
+ "&v=" + version;

Expand All @@ -35,4 +41,4 @@
window.addEventListener('load', riskifiedBeaconLoad, false);
}
</script>
<?php endif; ?>
<?php endif; ?>