Elevator class and test script #3
Conversation
|
|
||
| const float stepper_radius = 5.0; // Pulley radius in cm //! no se cual sea el radio correcto | ||
|
|
||
| // Method to convert a distance in centimeters to the corresponding number of steps. Returns number of steps required to move the given distance |
There was a problem hiding this comment.
I think these inline comments are a bit redundant, since the name of the variable it's self explanatory, it may look cleaner without the comments and line breaks
| void move_up(float distance); | ||
|
|
||
| // Method to move the elevator down by a specified distance in cm | ||
| void move_down(float distance); |
There was a problem hiding this comment.
According to the C++ style guide, function names should be named with CamelCase.
|
|
||
| class Elevator { | ||
| private: | ||
| Stepper left_stepper; // Stepper motor for the left side |
There was a problem hiding this comment.
According to the C++ style guide variables which are class members should be snake_case_ with a trailing underscore, just add the underscore
|
|
||
| const int steps_per_revolution; // Steps per revolution of the stepper motors | ||
|
|
||
| const float stepper_radius = 5.0; // Pulley radius in cm //! no se cual sea el radio correcto |
There was a problem hiding this comment.
If it's a constant, rename it to kStepperRadius according to the C++ style guide
| #include "Elevator.h" | ||
|
|
||
| //* Constructor | ||
| Elevator::Elevator(int stepsPerRevolution, int lPin1, int lPin2, int lPin3, int lPin4, int rPin1, int rPin2, int rPin3, int rPin4) |
There was a problem hiding this comment.
Even if the definition is longer, change the parameter to be full name (in general try to avoid abbreviations), for example leftPin1. You can also add line breaks to avoid having a long line
No description provided.