Added dialog for known places with schema #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oscar-gg
requested changes
Apr 6, 2025
|
|
||
|
|
||
| # Create a copy of areas.json for consistent testing | ||
| shutil.copy("areas.json", "test_areas.json") |
There was a problem hiding this comment.
maybe we can make a copy manually in the test folder, because I think this would always override test_areas.json, right?
There was a problem hiding this comment.
Also, I think the file doesn't exist, I got the following error when running deepeval test run test_room_identification.py
| @@ -0,0 +1,56 @@ | |||
| import json | |||
There was a problem hiding this comment.
When running this file I got the error:
ImportError while importing test module '/home/oscar/Repositories/home2/hri/packages/nlp/test/test_room_identification.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/home/oscar/miniconda3/lib/python3.12/importlib/__init__.py:90: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
test_room_identification.py:11: in <module>
from nlp.assets.dialogs import get_room_identification_dialog
E ModuleNotFoundError: No module named 'nlp'Please add the following to make the module visible:
import sys
sys.path.append("..")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test file, schema and dialog for room identification from known places list: living room, dinning room, kitchen, bedroom, entrance.